Late Night in Mixxx 2.2: Broadcast Button Hack

New or modified Mixxx skins

Moderators: garth, User Customization Moderators

Late Night in Mixxx 2.2: Broadcast Button Hack

Postby saphirantcross » Fri Nov 23, 2018 7:51 am

I am pleased with the new Late Night skin in Mixxx, especially the addition of the Broadcast button at the bottom right next to Record which makes triggering a stream easier. But I found with the button states, the wording of the button can be changed in XML in toolbar.xml, around Line 122:

Code: Select all
      <PushButton>
        <Size>82f,24f</Size>
        <TooltipId>skin_settings</TooltipId>
        <ObjectName>BroadcastButton</ObjectName>
        <NumberStates>4</NumberStates>
        <State>
          <Number>0</Number>
          <Text>Broadcast</Text>
        </State>
        <State>
          <Number>1</Number>
          <Text>Broadcast</Text>
        </State>
        <State>
          <Number>2</Number>
          <Text>Broadcast</Text>
        </State>
        <State>
          <Number>3</Number>
          <Text>Broadcast</Text>
        </State>
        <Connection>
          <ConfigKey persist="true">[Shoutcast],enabled</ConfigKey>
          <ButtonState>LeftButton</ButtonState>
        </Connection>
        <Connection>
          <ConfigKey persist="true">[Shoutcast],status</ConfigKey>
        </Connection>
      </PushButton>


I substituted the following:

Code: Select all
<PushButton>
        <Size>82f,24f</Size>
        <TooltipId>skin_settings</TooltipId>
        <ObjectName>BroadcastButton</ObjectName>
        <NumberStates>4</NumberStates>
        <State>
          <Number>0</Number>
          <Text>OFF AIR</Text>
        </State>
        <State>
          <Number>1</Number>
          <Text>STANDBY</Text>
        </State>
        <State>
          <Number>2</Number>
          <Text>ON AIR</Text>
        </State>
        <State>
          <Number>3</Number>
          <Text>ERROR</Text>
        </State>
        <Connection>
          <ConfigKey persist="true">[Shoutcast],enabled</ConfigKey>
          <ButtonState>LeftButton</ButtonState>
        </Connection>
        <Connection>
          <ConfigKey persist="true">[Shoutcast],status</ConfigKey>
        </Connection>
      </PushButton>


Instead of "BROADCAST", the button changes: black with "OFF AIR", click it to change to "STANDBY", then green and "ON AIR" if connected, or magenta and "ERROR" if not (along with a dialog box as to what happened.) The wording doesn't exceed the length of the button where it used to say BROADCAST, so it doesn't 'break' anything.

I didn't share this until now as I heard the skin developer was considering iconifying the button to be more consistent with the other skins. So instead of suggesting this as a fix, I thought I'd post it here for others if they wanted to elect to put it in or not.
saphirantcross
 
Posts: 14
Joined: Sat Mar 17, 2018 6:57 pm

Re: Late Night in Mixxx 2.2: Broadcast Button Hack

Postby ronso » Mon Dec 10, 2018 7:04 pm

nice idea!
maybe we'll add icons for to GUI toggles in LateNight but I doubt we'd remove the text then, so I'd say your 'hack' is an improvement and it'll probably get merged (just my opninion).
Regardless of what I think: always feel free to open a pull request @https://github.com/mixxxdj/mixxx or -for bigger tasks- ask first in the zulip chat https://mixxx.zulipchat.com before spending too much time. Worst thing that can happen is your idea gets rejected, but it'll start a discussion ;)
User avatar
ronso
 
Posts: 93
Joined: Mon Mar 02, 2015 7:41 pm


Return to Skins

Who is online

Users browsing this forum: No registered users and 1 guest